refactor(shapes): extract shared renderDataLabels utility#553
Merged
Conversation
Contributor
|
Preview is ready. |
|
📖 Docs Preview is ready. |
|
Visual Tests Report is ready. |
korvin89
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderDataLabelsfunction insrc/core/shapes/data-labels.tsin hover handlers
Bug fixes (found during refactor)
text-anchorwas never applied; now consistent with all other shapesfont-weightwas missing;fillwas set viaattr()instead ofstyle()(CSS wins over SVG attribute, so
style()is correct everywhere)textAnchorfield toHeatmapLabeltype and populated it inprepare-data (
'start', since x is already manually offset to center the text)Not included
treemap— uses a customTreemapLabelDatatype without per-labelstyle,reads style from
series.dataLabels.styledirectly. Aligning it is a separate task.